Comments on: Re Dumping currently loaded Firefox URLs

By: Jani Monoses: dumping open FF tab URLs using Javascript and shell stuff | Full-Linux.com

Sat, 04 Jul 2009 06:05:24 +0000

[...] perl and python solutions presented for dumping Firefox current session URLs are not very accurate if you navigate [...]

By: szbalint

szbalint — Thu, 02 Jul 2009 12:19:44 +0000

@drubin: Ah I see. I’ve just seen your post in the Planet Ubuntu aggregator and I assumed you were serious

By: drubin

drubin — Thu, 02 Jul 2009 12:12:26 +0000

@szbalint: That comment "perl is unreadble" should have been qualified as a personal joke we have in #ubuntu-begginers on freenode with ibuclaw & sdennie. @Dom: Thanks for your patch.

By: szbalint

szbalint — Thu, 02 Jul 2009 12:03:35 +0000

That might have come off as a bit harsh, however comparing your python version with the original Perl implementation, I have to say that the Perl version is a lot more robust and readable.

Even if you don’t like parsing JSON with regular expressions, it would have been a simple fix to “use JSON;”. That is however an implementation detail and I don’t see how that would imply that Perl is unreadable.

By: Dom

Dom — Thu, 02 Jul 2009 12:01:24 +0000

hmm, looks like your blog dropped the formatting

http://paste.ubuntu.com/208082/

By: Dom

Dom — Thu, 02 Jul 2009 11:59:22 +0000

thanks for this! had to tweak it slightly to cope with page titles containing unicode characters and ‘Untitled’ tabs, here’s the patch:

— old/ff-pages.py 2009-07-02 11:46:23.000000000 +0100
+++ new/ff-pages.py 2009-07-02 12:57:57.546325791 +0100
@@ -8,5 +8,6 @@
print ‘Window %s’% (i+1)
for tabs in window['tabs']:
entry = tabs['entries']
- if entry[len(entry)-1].has_key(‘title’) and entry[len(entry)-1].has_key(‘url’):
- print ‘\tTitle: %s Url %s’% (entry[len(entry)-1]['title'], entry[len(entry)-1]['url'])
+ if len(entry) > 0 and entry[len(entry)-1].has_key(‘title’) and entry[len(entry)-1].has_key(‘url’):
+ s = ‘\tTitle: %s Url %s’ % (entry[len(entry)-1]['title'], entry[len(entry)-1]['url'])
+ print unicode(s).encode(‘utf8′)

By: szbalint

szbalint — Thu, 02 Jul 2009 11:51:14 +0000

Perl is not unreadable, you’re just incompetent and never bothered to look properly.